vienalatina/apps/board/gitea.py
Claude e11016a8e9
Refuse before the form, not after the password
A member followed his invitation link, chose a password, typed it twice,
pressed save, and was shown the name of an environment variable. The
server knew from the first byte of that request that it could not save
anything: without GITEA_ADMIN_TOKEN it cannot set a password in Gitea.
It asked him to do the work anyway.

Three places had the same shape, all now checked up front through a new
gitea.admin_configured(), mirroring mail.configured():

- the invitation page answers 503 with an explanation and no password
  field, identically for a real and an invented token so it cannot be
  used to probe for live ones
- /recuperar refuses instead of mailing a link to a page that could only
  apologise — and its deliberately identical answer would have hidden
  that from the admin as well as the member
- the sign-in page stops offering recovery it cannot complete

Also: a 404 from admin_set_password now names the real cause. A member
added without "crear también su cuenta" has no Gitea account, so the
password change is aimed at nothing, and "Gitea rechazó el cambio de
contraseña (404)" blames Gitea for an account that was never made.

deploy-board.sh warns about settings that are present but empty. The
previous check looked for missing names, and GITEA_ADMIN_TOKEN= has a
name — which is why the deploy that led to this said nothing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NizVpJ2dwzCbjCrTLCjeHn
2026-09-25 19:20:44 +00:00

297 lines
11 KiB
Python

"""The only place that talks to Gitea.
Three unrelated conversations happen here, worth keeping apart in your head:
* **Sign-in** uses OAuth2 on behalf of the person at the keyboard. The app is
registered as a *confidential* client with a secret, which it can hold
because it runs on the server. The Decap CMS app is the opposite — a public
client using PKCE — because that one runs in the visitor's browser and has
nowhere to keep a secret.
* **Creating an account** uses a site-admin token belonging to the instance,
not to any member. That token can create and modify any Gitea user, so the
environment holding it is as sensitive as Gitea's own admin password.
* **Reading and writing content** uses the signed-in member's *own* access
token. Commits are then attributed to the person who actually wrote the post,
and Gitea's permissions apply unchanged — the editor cannot grant write access
to somebody who does not already have it.
"""
from __future__ import annotations
import base64
import secrets
import string
from urllib.parse import quote, urlencode
import requests
from flask import current_app
TIMEOUT = 10
class GiteaError(RuntimeError):
"""Gitea refused a request. The message is safe to show a member."""
class StaleFile(GiteaError):
"""The file changed since it was loaded into the form.
Gitea rejects a write whose `sha` no longer matches the branch, which is
what makes two people editing one post a visible conflict rather than a
silent overwrite of whoever saved first.
"""
def _base() -> str:
return current_app.config["GITEA_URL"].rstrip("/")
def _api(path: str) -> str:
return f"{_base()}/api/v1{path}"
def _repo() -> str:
return current_app.config["CONTENT_REPO"].strip("/")
def _branch() -> str:
return current_app.config["CONTENT_BRANCH"]
# --- sign-in -------------------------------------------------------------
def authorize_url(state: str, redirect_uri: str) -> str:
query = urlencode({
"client_id": current_app.config["OAUTH_CLIENT_ID"],
"redirect_uri": redirect_uri,
"response_type": "code",
"state": state,
})
return f"{_base()}/login/oauth/authorize?{query}"
def _token_request(payload: dict) -> dict:
response = requests.post(
f"{_base()}/login/oauth/access_token",
json={
"client_id": current_app.config["OAUTH_CLIENT_ID"],
"client_secret": current_app.config["OAUTH_CLIENT_SECRET"],
**payload,
},
timeout=TIMEOUT,
)
if response.status_code != 200:
raise GiteaError("No se pudo completar el inicio de sesión.")
data = response.json()
if not data.get("access_token"):
raise GiteaError("Gitea no devolvió un token de acceso.")
return data
def exchange_code(code: str, redirect_uri: str) -> dict:
"""Returns the whole token response, not just the access token.
The refresh token matters: Gitea's access tokens last about an hour, and
without refreshing, saving a post would start failing partway through an
afternoon's work for no reason the writer could understand.
"""
return _token_request({
"code": code,
"grant_type": "authorization_code",
"redirect_uri": redirect_uri,
})
def refresh_token(token: str) -> dict:
return _token_request({"refresh_token": token, "grant_type": "refresh_token"})
def fetch_user(token: str) -> dict:
response = requests.get(
_api("/user"),
headers={"Authorization": f"Bearer {token}"},
timeout=TIMEOUT,
)
if response.status_code != 200:
raise GiteaError("No se pudo leer el perfil desde Gitea.")
return response.json()
# --- account creation (site-admin token) ---------------------------------
def admin_configured() -> bool:
"""Whether this server holds a site-admin token.
Without one it can neither create accounts nor set passwords. That is a
supported configuration — server-setup.md §11.2 says why somebody might
choose it — and it is why both calls below refuse before reaching Gitea.
Exposed as a predicate so a screen can say so *before* asking somebody to
fill in a form that cannot be saved, the way `mail.configured()` is used.
"""
return bool(current_app.config.get("ADMIN_TOKEN"))
def generate_password() -> str:
# Shown once to the admin, then changed by the member on first login.
# Punctuation is left out on purpose: this gets read aloud or copied by
# hand, and a password nobody can transcribe gets written on a note.
alphabet = string.ascii_letters + string.digits
return "".join(secrets.choice(alphabet) for _ in range(16))
def admin_create_user(login: str, email: str, full_name: str, password: str) -> None:
token = current_app.config.get("ADMIN_TOKEN")
if not token:
raise GiteaError(
"Falta GITEA_ADMIN_TOKEN: el servidor no puede crear cuentas nuevas."
)
response = requests.post(
_api("/admin/users"),
headers={"Authorization": f"token {token}"},
json={
"username": login,
"email": email,
"full_name": full_name,
"password": password,
"must_change_password": True,
"send_notify": False,
},
timeout=TIMEOUT,
)
if response.status_code in (201, 200):
return
if response.status_code == 422:
raise GiteaError("Ese usuario o correo ya existe en Gitea.")
if response.status_code in (401, 403):
raise GiteaError("El token de administración de Gitea no es válido.")
raise GiteaError(f"Gitea rechazó la creación del usuario ({response.status_code}).")
def admin_set_password(login: str, password: str) -> None:
"""Set a member's password on their behalf, after they chose it here.
This is what lets the whole invitation and reset flow stay inside
/comunidad/ instead of handing people to Gitea, whose own recovery page is
dead without a mailer anyway.
`login_name` and `source_id` are sent although nothing about them changes:
Gitea's EditUserOption has historically treated them as required, and
omitting them has been reported to move a local account onto a different
authentication source. For a local user they are the username and 0, so
sending them is a no-op that avoids the question.
"""
token = current_app.config.get("ADMIN_TOKEN")
if not token:
raise GiteaError(
"Falta GITEA_ADMIN_TOKEN: el servidor no puede cambiar contraseñas."
)
response = requests.patch(
_api(f"/admin/users/{quote(login, safe='')}"),
headers={"Authorization": f"token {token}"},
json={
"password": password,
"must_change_password": False,
"login_name": login,
"source_id": 0,
},
timeout=TIMEOUT,
)
if response.status_code in (200, 201):
return
if response.status_code == 422:
# Gitea enforces its own minimum length and complexity, and its message
# is in the admin's language rather than the member's, so it is not
# passed through.
raise GiteaError("Gitea rechazó esa contraseña. Prueba con una más larga.")
if response.status_code in (401, 403):
raise GiteaError("El token de administración de Gitea no es válido.")
if response.status_code == 404:
# Reachable: a member can be added here without ticking "crear también
# su cuenta", and then invited. Everything works right up to this call,
# which is asked to change the password of an account that was never
# made. A bare "(404)" sends the admin looking at the wrong thing.
raise GiteaError(
f"No existe la cuenta «{login}» en Gitea, así que no se le puede "
"poner contraseña. Pide a un administrador que la cree."
)
raise GiteaError(f"Gitea rechazó el cambio de contraseña ({response.status_code}).")
# --- content (the member's own token) ------------------------------------
def _contents_url(path: str) -> str:
# quote() with no safe characters: a path segment is data, not structure.
return _api(f"/repos/{_repo()}/contents/{quote(path, safe='/')}")
def _content_request(method: str, url: str, token: str, **kwargs):
response = requests.request(
method, url,
headers={"Authorization": f"Bearer {token}"},
timeout=TIMEOUT,
**kwargs,
)
if response.status_code in (401, 403):
raise PermissionError("gitea-unauthorised") # caller refreshes and retries
return response
def list_directory(path: str, token: str) -> list[dict]:
"""Names and shas only — the contents API does not return file bodies here."""
response = _content_request("GET", _contents_url(path), token,
params={"ref": _branch()})
if response.status_code == 404:
return [] # an empty content folder is normal, not an error
if response.status_code != 200:
raise GiteaError(f"Gitea no devolvió la lista de archivos ({response.status_code}).")
payload = response.json()
return [item for item in payload if item.get("type") == "file"]
def read_file(path: str, token: str) -> tuple[str, str]:
"""(text, sha). The sha comes back so a later write can prove it is current."""
response = _content_request("GET", _contents_url(path), token,
params={"ref": _branch()})
if response.status_code == 404:
raise GiteaError("Ese archivo ya no existe.")
if response.status_code != 200:
raise GiteaError(f"No se pudo leer el archivo ({response.status_code}).")
payload = response.json()
text = base64.b64decode(payload.get("content", "")).decode("utf-8")
return text, payload.get("sha", "")
def write_file(path: str, data: bytes, message: str, token: str,
sha: str | None = None) -> str:
"""Create when `sha` is None, update otherwise. Returns the new sha."""
body = {
"content": base64.b64encode(data).decode("ascii"),
"message": message,
"branch": _branch(),
}
if sha:
body["sha"] = sha
response = _content_request("PUT" if sha else "POST", _contents_url(path),
token, json=body)
if response.status_code in (200, 201):
return response.json().get("content", {}).get("sha", "")
if response.status_code in (409, 422):
raise StaleFile(
"Alguien más guardó este archivo mientras lo editabas. "
"Vuelve a abrirlo para no perder su trabajo."
)
raise GiteaError(f"Gitea rechazó el guardado ({response.status_code}).")
def delete_file(path: str, sha: str, message: str, token: str) -> None:
response = _content_request("DELETE", _contents_url(path), token, json={
"sha": sha, "message": message, "branch": _branch(),
})
if response.status_code in (200, 204):
return
if response.status_code in (409, 422):
raise StaleFile("El archivo cambió desde que lo abriste. Recarga la lista.")
raise GiteaError(f"Gitea rechazó el borrado ({response.status_code}).")