b90cbd2a9f
Three complaints, one cause. Logging out could not finish because the session belonged to another server, whose logout is POST-only and unreachable from here. "Ese usuario ya está en uso" for somebody absent from Miembros, because erase_member deleted our row and left the git account standing — two stores of users, one of them showing. And the hand-off to a differently-designed domain, with a Forgot password that could never work. All three followed from delegating identity, so it is no longer delegated. Members now sign in at /comunidad/login against a scrypt hash in our own database, via werkzeug.security, which arrives with Flask. They have no account on the git server at all, which makes the collision impossible rather than fixed. Logout is one click. This removes more than it adds: the OAuth round trip, the client registration, tokens.py with its refresh-before-expiry logic, the gitea_tokens table, and the logged-out page that existed to apologise for a logout that did not log you out. The editor keeps per-writer attribution without per-writer tokens: one CONTENT_TOKEN commits, and each commit names its author, which Gitea's contents API supports and a test now asserts. CONTENT_TOKEN falls back to GITEA_ADMIN_TOKEN so nothing breaks on deploy, but it only needs write access to one repository, while the admin token can modify every account on the instance — and now has no remaining job. The refusals are the interesting part. Unknown name, wrong password, suspended member and invited-but-never-arrived all answer identically, asserted by comparing the rendered bytes. The hash check runs against a decoy even when there is no such member, so an unknown name does not answer faster. Attempts are rate limited, counted inside SQLite for the reason invites.py documents. A NULL hash never matches anything. Migration 2 adds password_hash and drops the dead OAuth tokens. Everyone starts NULL, including the owner, so scripts/set-password.sh exists and was tested before this could ship: it prompts without echo, never takes the password as an argument where ps would show it, and refuses a short one or an unknown member. Rehearsed against a rebuilt copy of the server's database: starts, keeps the photo, drops the tokens table, serves a login form with no redirect, signs in, signs out, stays out. 223 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NizVpJ2dwzCbjCrTLCjeHn
69 lines
2.5 KiB
Bash
Executable File
69 lines
2.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Set a member's password directly, without email.
|
|
#
|
|
# The way back in. Every member's password_hash starts NULL, including the
|
|
# owner's, and the normal route to a first password is the invitation or
|
|
# "¿olvidaste tu contraseña?" — both of which go by email. If the mailbox is
|
|
# having a bad week and nobody can sign in, this is the only door left.
|
|
#
|
|
# sudo bash scripts/set-password.sh pablo
|
|
#
|
|
# The password is typed at a prompt and never echoed, never passed as an
|
|
# argument, and never written to shell history. It is hashed by the same code
|
|
# the application uses, inside the running container, so there is no second
|
|
# implementation to drift.
|
|
#
|
|
# Run it from the repository, on the server. It needs the board container up.
|
|
|
|
set -euo pipefail
|
|
|
|
LOGIN="${1:-}"
|
|
SERVICE="${BOARD_SERVICE:-board}"
|
|
TARGET="${BOARD_DIR:-/srv/board}"
|
|
|
|
if [ -z "$LOGIN" ]; then
|
|
echo "Usage: sudo bash scripts/set-password.sh <usuario>" >&2
|
|
exit 1
|
|
fi
|
|
|
|
cd "$TARGET"
|
|
|
|
if ! docker compose ps --status running --services 2>/dev/null | grep -qx "$SERVICE"; then
|
|
echo "The $SERVICE container is not running — start it first: docker compose up -d" >&2
|
|
exit 1
|
|
fi
|
|
|
|
# -s so it is not echoed; the confirmation catches a typo that would otherwise
|
|
# lock the account this script exists to unlock.
|
|
read -rsp "Nueva contraseña para $LOGIN: " PASSWORD; echo
|
|
read -rsp "Repítela: " CONFIRM; echo
|
|
if [ "$PASSWORD" != "$CONFIRM" ]; then
|
|
echo "No coinciden. Nada cambiado." >&2
|
|
exit 1
|
|
fi
|
|
|
|
# Through the environment rather than the command line: an argument is visible
|
|
# in `ps` to every user on the box for as long as the process lives.
|
|
PASSWORD="$PASSWORD" docker compose exec -T -e PASSWORD "$SERVICE" python - "$LOGIN" <<'PY'
|
|
import os, sqlite3, sys
|
|
sys.path.insert(0, "/srv")
|
|
from apps.board.passwords import MINIMUM, hash_password
|
|
|
|
login, password = sys.argv[1], os.environ["PASSWORD"]
|
|
if len(password) < MINIMUM:
|
|
sys.exit(f"La contraseña necesita al menos {MINIMUM} caracteres. Nada cambiado.")
|
|
|
|
db = sqlite3.connect(os.environ.get("BOARD_DB", "/data/board.db"), isolation_level=None)
|
|
changed = db.execute(
|
|
"""UPDATE members SET password_hash = ?
|
|
WHERE gitea_login = ? COLLATE NOCASE
|
|
AND role IN ('owner', 'admin', 'user')""",
|
|
(hash_password(password), login),
|
|
).rowcount
|
|
if not changed:
|
|
sys.exit(f"No hay ningún miembro activo llamado «{login}». Nada cambiado.")
|
|
print(f"Contraseña actualizada para «{login}». Ya puede entrar en /comunidad/.")
|
|
PY
|
|
|
|
unset PASSWORD CONFIRM
|