vienalatina/apps/board/app.py
Claude 635372d7a2
Write the site from the members area instead of Decap
Decap looks like a different product because it cannot be made to look like
this one: its maintainer's answer is override the CSS and accept that class
names move between releases, or fork it and carry that forever. Neither is
worth building on, so editing moves into the app that already has the site's
design and this project's tests.

Posts are files in git, so the editor is a form that commits a file through
Gitea's contents API. No working copy, no queue, no new state, and no way for
the pipeline to tell which editor wrote the file — which is what makes running
both at once safe. Decap keeps working; nothing here removes it, and the
fallback if something is missing is switching tabs.

Filenames and frontmatter are not this module's to invent. They are the
contract scripts/translate.py reads: `<basename>.es.md` is what split_lang()
parses, the date prefix is what keeps two posts with one title off a single
URL, and the absence of `translated_from` is what marks a file as something a
person wrote. Several tests import translate.py and run its own parser over
what the editor produced, because a file it cannot parse publishes in Spanish
and is never translated, with nothing reported anywhere.

Commits carry the writer's own Gitea account rather than a bot's, so history
says who wrote each post and Gitea's permissions apply unchanged. That needs
their access token, which lives in the database and never in a cookie: Flask
signs cookies but does not encrypt them, and a token is enough to commit as its
owner. Gitea expires tokens after about an hour, so they refresh ahead of
expiry and retry once on rejection — without that, saving would start failing
partway through an afternoon for no reason the writer could see.

Publishing is admin-only. Posting to the internal board and publishing to the
public site are different permissions, and the second is the larger grant.

Listing caches frontmatter against the git blob sha, because the contents API
returns names without bodies: that turns one request per post on every page
load into one request in total, and needs no invalidation, since a sha changes
only when the file does.

Verified: 97 checks. The filename translate.py parses, an authored source that
is_generated() rejects, the freeze toggle round-tripping, a stale sha refused
with the other edit intact, six filename shapes that must 404 including a
generated sibling, plain members refused, an SVG rejected as an image, uploads
not colliding, the cache reading each file once and refreshing when it changes,
and a preview that renders markdown, escapes script tags and publishes nothing.
Smoke-tested live: routes register and gate correctly.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NizVpJ2dwzCbjCrTLCjeHn
2026-09-25 15:07:31 +00:00

143 lines
6.2 KiB
Python

"""Application factory for the members area.
Served at /comunidad/ on the main domain, behind Caddy, alongside the static
Hugo output and Decap. It is the only part of vienalatina.com that runs code to
answer a request; everything else is a file on disk.
"""
from __future__ import annotations
import os
from datetime import datetime, timezone
from flask import Flask, render_template
from werkzeug.middleware.proxy_fix import ProxyFix
from .db import close_db, init_db
from .security import check_csrf, csrf_token
URL_PREFIX = "/comunidad"
def _env_flag(name: str, default: bool) -> bool:
raw = os.environ.get(name)
if raw is None:
return default
return raw.strip().lower() in ("1", "true", "yes", "on")
def create_app(overrides: dict | None = None) -> Flask:
# Static files have to live under the prefix too: Caddy only forwards
# /comunidad/*, so a default /static/… would fall through to the Hugo
# file_server and 404.
app = Flask(__name__, static_url_path=f"{URL_PREFIX}/static")
# Caddy terminates TLS and forwards plain HTTP, so without this the app
# believes every request arrived unencrypted and sends its redirects to
# http:// — an extra hop, and a moment where the session cookie could
# travel in the clear.
#
# Trusting these headers is only safe because the container binds to
# 127.0.0.1 and nothing but Caddy can reach it. Expose the port and a
# client can forge its own address and scheme.
app.wsgi_app = ProxyFix(app.wsgi_app, x_for=1, x_proto=1, x_host=1)
app.config.update(
SECRET_KEY=os.environ.get("BOARD_SECRET_KEY", ""),
DB_PATH=os.environ.get("BOARD_DB", "/data/board.db"),
GITEA_URL=os.environ.get("GITEA_URL", "https://git.vienalatina.com"),
OAUTH_CLIENT_ID=os.environ.get("BOARD_OAUTH_CLIENT_ID", ""),
OAUTH_CLIENT_SECRET=os.environ.get("BOARD_OAUTH_CLIENT_SECRET", ""),
ADMIN_TOKEN=os.environ.get("GITEA_ADMIN_TOKEN", ""),
OWNER_LOGIN=os.environ.get("BOARD_OWNER", ""),
BASE_URL=os.environ.get("BOARD_BASE_URL", "https://vienalatina.com"),
# The repository the editor commits to — the same one Woodpecker builds,
# which is what makes publishing from here indistinguishable from
# publishing from Decap as far as the pipeline is concerned.
CONTENT_REPO=os.environ.get("CONTENT_REPO", "pablo/vienalatina"),
CONTENT_BRANCH=os.environ.get("CONTENT_BRANCH", "main"),
URL_PREFIX=URL_PREFIX,
COOLDOWN_SECONDS=int(os.environ.get("BOARD_COOLDOWN_SECONDS", "20")),
SESSION_COOKIE_HTTPONLY=True,
SESSION_COOKIE_SAMESITE="Lax",
# Off only for tests and local http; on the server this must stay true
# or the session cookie travels in cleartext the first time someone
# types the address without https.
SESSION_COOKIE_SECURE=_env_flag("BOARD_COOKIE_SECURE", True),
SESSION_COOKIE_NAME="vl_board",
# Generous enough for a photo off a phone. The board itself needs a
# fraction of this; the editor uploads images, and a writer whose
# picture is silently refused has no way to tell what went wrong.
MAX_CONTENT_LENGTH=10 * 1024 * 1024,
UPLOAD_MAX_BYTES=int(os.environ.get("BOARD_UPLOAD_MAX_BYTES", 8 * 1024 * 1024)),
)
if overrides:
app.config.update(overrides)
if not app.config["SECRET_KEY"]:
# A generated key would "work" and silently log everyone out on every
# restart, which is a confusing way to find out the variable is unset.
raise RuntimeError("BOARD_SECRET_KEY is required (generate one with `openssl rand -hex 32`).")
from . import auth, board, content, members
app.register_blueprint(auth.bp, url_prefix=URL_PREFIX)
app.register_blueprint(members.bp, url_prefix=URL_PREFIX)
app.register_blueprint(content.bp, url_prefix=URL_PREFIX)
app.register_blueprint(board.bp, url_prefix=URL_PREFIX)
app.teardown_appcontext(close_db)
app.jinja_env.globals["csrf_token"] = csrf_token
app.jinja_env.globals["url_prefix"] = URL_PREFIX
@app.context_processor
def _year():
return {"current_year": datetime.now(timezone.utc).year}
@app.before_request
def _before():
# Order matters: reject forged writes before any handler can act on
# them, but after the member is known so errors can render the chrome.
auth.load_member()
check_csrf()
@app.after_request
def _harden(response):
# The members area must never appear in a search result. Both halves
# are needed: robots.txt asks crawlers not to fetch, this tells the
# ones that fetched anyway not to index.
response.headers["X-Robots-Tag"] = "noindex, nofollow"
response.headers["X-Content-Type-Options"] = "nosniff"
response.headers["Referrer-Policy"] = "same-origin"
# No 'unsafe-inline'. Two consequences worth knowing rather than
# rediscovering: an onsubmit="" or onclick="" attribute in a template
# is silently ignored (see static/board.js), and a markdown image
# pointing at another site will not load — which for a private board is
# the right answer anyway, since an external image is a request that
# tells someone else who read the thread and when.
response.headers["Content-Security-Policy"] = (
"default-src 'self'; img-src 'self' data:; frame-ancestors 'none'"
)
return response
@app.errorhandler(400)
def _bad_request(error):
return render_template("error.html", code=400,
message=getattr(error, "description", "Solicitud inválida.")), 400
@app.errorhandler(403)
def _forbidden(_error):
return render_template("error.html", code=403,
message="No tienes permiso para hacer esto."), 403
@app.errorhandler(404)
def _not_found(_error):
return render_template("error.html", code=404,
message="No encontramos esa página."), 404
@app.errorhandler(413)
def _too_large(_error):
return render_template("error.html", code=413,
message="El mensaje es demasiado largo."), 413
init_db(app)
return app