e95c732c6f
Until now an admin created an account, the password appeared once on screen,
and that was the only copy. Gitea's Forgot password answers "Account recovery
is disabled because no email is set up", because this server has never been
able to send mail. Every route a member had to a password of their own was
closed, which made the members area unusable by anyone not standing next to the
owner.
Now: the admin enters a username and an email, the server creates the Gitea
account with a random password nobody ever sees — the admin included — and the
member is emailed a link to a Viena Latina page where they choose their own.
The same mechanism gives "¿Olvidaste tu contraseña?" that works, replacing
Gitea's dead page. Nobody leaves the site for either, which is possible because
PATCH /admin/users/{username} accepts a password.
A link is enough to take an account, so it is treated as a credential: single
use, short-lived, stored only as a SHA-256, and invalidated when a newer one is
issued so an older email stops working. SHA-256 rather than a password hash
because these are 32 random bytes, not something a person chose — there is no
dictionary to slow down. Recovery answers identically for a known and an
unknown address, or the form becomes a way to enumerate members one address at
a time, and stops after three tries so it cannot be used to mail-bomb somebody
using this server's reputation.
Rejecting a password deliberately does not spend the token. A typo must not
lock somebody out of an account they have never reached.
If the mail fails the admin is shown the link instead. The account exists
either way, so the difference is between a delayed invitation and a person who
simply never gets in.
Found while testing: the rate limit did not work at all. created_at is written
by SQLite as "2026-09-25 15:00:00" and I compared it against Python's
"2026-09-25T15:00:00+00:00"; a space sorts before T, so every row looked older
than any threshold and the limit silently never fired. It is now compared
inside SQLite, where the format and the clock are the same one.
Also drops two tabs from the sign-in page: OpenID, which nobody here will use,
and Register, which contradicted DISABLE_REGISTRATION and invited people to try
something the server then refused.
Verified: 126 checks. Tokens are hashed at rest, work once, expire, die when
reissued, and are refused for a suspended member; a short password and a Gitea
rejection both leave the link usable; recovery is indistinguishable for known
and unknown addresses and stops at three; creating a member emails them and
shows no password; a failed send surfaces the link.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NizVpJ2dwzCbjCrTLCjeHn
115 lines
3.3 KiB
Python
115 lines
3.3 KiB
Python
"""Sending mail, through the association's own mailbox.
|
|
|
|
`smtplib` from the standard library rather than a mail framework: this sends
|
|
two kinds of message, both short and both plain text. A dependency would buy
|
|
templating and queueing that nothing here asks for.
|
|
|
|
Plain text only, no HTML alternative. An invitation is a sentence and a link —
|
|
HTML would add a second body to keep in step with the first, another place for
|
|
an escaping mistake, and a slightly worse chance of landing in the inbox rather
|
|
than the spam folder.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import smtplib
|
|
import ssl
|
|
from email.message import EmailMessage
|
|
|
|
from flask import current_app
|
|
|
|
|
|
class MailNotConfigured(RuntimeError):
|
|
"""No SMTP host is set, so this server cannot send anything."""
|
|
|
|
|
|
class MailFailed(RuntimeError):
|
|
"""The mail server refused or could not be reached."""
|
|
|
|
|
|
def configured() -> bool:
|
|
return bool(current_app.config.get("MAIL_HOST"))
|
|
|
|
|
|
def send(to: str, subject: str, body: str) -> None:
|
|
if not configured():
|
|
raise MailNotConfigured(
|
|
"No hay servidor de correo configurado (MAIL_HOST)."
|
|
)
|
|
|
|
config = current_app.config
|
|
message = EmailMessage()
|
|
message["From"] = config["MAIL_FROM"]
|
|
message["To"] = to
|
|
message["Subject"] = subject
|
|
message.set_content(body)
|
|
|
|
host, port = config["MAIL_HOST"], int(config["MAIL_PORT"])
|
|
security = (config.get("MAIL_SECURITY") or "starttls").lower()
|
|
|
|
try:
|
|
# 465 speaks TLS from the first byte; 587 starts in the clear and
|
|
# upgrades. Getting this pair wrong is the usual reason a mailbox that
|
|
# works in a mail client fails here, so it is configuration rather than
|
|
# a guess from the port number.
|
|
if security == "ssl":
|
|
server = smtplib.SMTP_SSL(host, port, timeout=20,
|
|
context=ssl.create_default_context())
|
|
else:
|
|
server = smtplib.SMTP(host, port, timeout=20)
|
|
|
|
with server:
|
|
if security == "starttls":
|
|
server.starttls(context=ssl.create_default_context())
|
|
if config.get("MAIL_USER"):
|
|
server.login(config["MAIL_USER"], config["MAIL_PASSWORD"])
|
|
server.send_message(message)
|
|
except (smtplib.SMTPException, OSError, ssl.SSLError) as exc:
|
|
# The caller decides what to do about it — for an invitation that means
|
|
# showing the admin the link so the member is not stranded.
|
|
current_app.logger.warning("Mail to %s failed: %s", to, exc)
|
|
raise MailFailed(str(exc)) from exc
|
|
|
|
|
|
def send_invite(to: str, name: str, url: str) -> None:
|
|
send(
|
|
to,
|
|
"Tu acceso a Viena Latina",
|
|
f"""Hola {name},
|
|
|
|
Te damos de alta en el área de la comunidad de Viena Latina.
|
|
|
|
Elige tu contraseña aquí:
|
|
|
|
{url}
|
|
|
|
El enlace sirve una sola vez y caduca en 7 días. Si caduca, pide a un
|
|
administrador que te envíe uno nuevo.
|
|
|
|
Si no esperabas este correo, puedes ignorarlo.
|
|
|
|
— Viena Latina
|
|
""",
|
|
)
|
|
|
|
|
|
def send_reset(to: str, name: str, url: str) -> None:
|
|
send(
|
|
to,
|
|
"Restablecer tu contraseña — Viena Latina",
|
|
f"""Hola {name},
|
|
|
|
Alguien pidió restablecer la contraseña de tu cuenta.
|
|
|
|
Si fuiste tú, elige una nueva aquí:
|
|
|
|
{url}
|
|
|
|
El enlace sirve una sola vez y caduca en 1 hora.
|
|
|
|
Si no fuiste tú, ignora este correo: tu contraseña no ha cambiado.
|
|
|
|
— Viena Latina
|
|
""",
|
|
)
|