6ac814475e
Everything on this site so far has been a file built from git. This is the first component that runs code to answer a request and the first whose data git does not hold, so the trade is stated in the README and the backup script is not optional. Roles are owner, admin and user. The owner is seeded once from BOARD_OWNER and cannot be seeded again, because otherwise editing a compose file would be a quieter way to take the top role than asking for it; ownership moves only by transfer, inside the app. There is exactly one owner and a partial unique index enforces it, so the invariant holds even when a handler is wrong. The owner is beyond suspension and demotion by everyone, themselves included. Only the owner makes admins; admins make users. Sign-in goes through Gitea as a confidential OAuth client — the opposite of Decap, which has to be public because it runs in the browser. The rule the whole thing rests on is that a Gitea account is not a membership: entry needs an active row in `members`, or every account on the instance is a member, starting with the translations bot. Admins can delete any post; nobody can edit anyone else's, admins included. Taking a post down is visible to its author. Quietly rewriting it is not, and an admin who could do that could leave a sentence attributed to someone who never wrote it. The plan said admins could do both; this is the one place the implementation departs from it. Markdown renders with raw HTML disabled, which is the entire XSS defence and the reason there is no sanitiser: the renderer emits only its own tags and escapes the rest. The CSP carries no 'unsafe-inline', which makes an inline onsubmit silently inert rather than broken, so the confirmation dialogs live in a static file and a test fails any template that grows an inline handler. GDPR is in scope rather than deferred: erasure removes the member row and moves their authorship to a tombstone so the conversations around them still read, and any member can download their own writing. Verified: 63 checks pass, covering the membership gate, every role predicate, a direct insert of a second owner being refused by the index, atomic ownership transfer, CSRF, an offsite login redirect, script tags rendering as text, soft deletes leaving both listings and exports, and the member screens rendering for each role. Smoke-tested live: headers, both static assets, and the bare /comunidad redirect that the Caddy matcher has to cover. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NizVpJ2dwzCbjCrTLCjeHn
103 lines
3.5 KiB
Python
103 lines
3.5 KiB
Python
"""SQLite access for the members area.
|
|
|
|
One connection per request, closed when the request ends. SQLite is enough
|
|
here by a wide margin: a trusted group of tens of people generates a handful
|
|
of writes a day, and keeping the database a single file on disk means the
|
|
backup story is `cp`, which matters more than throughput nobody will use.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sqlite3
|
|
from pathlib import Path
|
|
|
|
from flask import current_app, g
|
|
|
|
SCHEMA_PATH = Path(__file__).with_name("schema.sql")
|
|
|
|
# Authorship of a removed member is reassigned to this row rather than deleted,
|
|
# so their threads keep their shape and replies to them still make sense. It can
|
|
# never log in: the login gate requires an active member holding a real role.
|
|
TOMBSTONE_LOGIN = "__removed__"
|
|
TOMBSTONE_NAME = "Miembro eliminado"
|
|
|
|
|
|
def connect(path: str) -> sqlite3.Connection:
|
|
# isolation_level=None puts the driver in autocommit mode, so the only
|
|
# transactions are the ones written explicitly with BEGIN. Python's
|
|
# implicit-transaction behaviour is surprising often enough to be worth
|
|
# opting out of entirely.
|
|
conn = sqlite3.connect(path, isolation_level=None)
|
|
conn.row_factory = sqlite3.Row
|
|
conn.execute("PRAGMA foreign_keys = ON")
|
|
conn.execute("PRAGMA journal_mode = WAL")
|
|
conn.execute("PRAGMA busy_timeout = 5000")
|
|
return conn
|
|
|
|
|
|
def get_db() -> sqlite3.Connection:
|
|
if "db" not in g:
|
|
g.db = connect(current_app.config["DB_PATH"])
|
|
return g.db
|
|
|
|
|
|
def close_db(_exception=None) -> None:
|
|
db = g.pop("db", None)
|
|
if db is not None:
|
|
db.close()
|
|
|
|
|
|
def init_db(app) -> None:
|
|
"""Apply the schema and make sure the fixed rows exist."""
|
|
Path(app.config["DB_PATH"]).parent.mkdir(parents=True, exist_ok=True)
|
|
db = connect(app.config["DB_PATH"])
|
|
try:
|
|
db.executescript(SCHEMA_PATH.read_text(encoding="utf-8"))
|
|
_ensure_tombstone(db)
|
|
_seed_owner(db, app)
|
|
finally:
|
|
db.close()
|
|
|
|
|
|
def _ensure_tombstone(db: sqlite3.Connection) -> None:
|
|
db.execute(
|
|
"""INSERT INTO members (gitea_login, display_name, role, active)
|
|
VALUES (?, ?, 'tombstone', 0)
|
|
ON CONFLICT(gitea_login) DO NOTHING""",
|
|
(TOMBSTONE_LOGIN, TOMBSTONE_NAME),
|
|
)
|
|
|
|
|
|
def _seed_owner(db: sqlite3.Connection, app) -> None:
|
|
"""Create the first owner from BOARD_OWNER, once.
|
|
|
|
Deliberately refuses to change an existing owner. Were this to overwrite,
|
|
anyone who could edit the environment could hand themselves ownership by
|
|
restarting the container — which is a quieter privilege escalation than it
|
|
looks, since editing a compose file draws far less attention than asking
|
|
the owner for access.
|
|
"""
|
|
login = (app.config.get("OWNER_LOGIN") or "").strip()
|
|
existing = db.execute("SELECT gitea_login FROM members WHERE role = 'owner'").fetchone()
|
|
|
|
if existing:
|
|
if login and existing["gitea_login"].lower() != login.lower():
|
|
app.logger.warning(
|
|
"BOARD_OWNER is %r but the owner is %r; leaving it alone. "
|
|
"Transfer ownership from inside the app instead.",
|
|
login, existing["gitea_login"],
|
|
)
|
|
return
|
|
|
|
if not login:
|
|
app.logger.warning("No owner yet and BOARD_OWNER is unset — nobody can sign in.")
|
|
return
|
|
|
|
db.execute(
|
|
"""INSERT INTO members (gitea_login, display_name, role, active)
|
|
VALUES (?, ?, 'owner', 1)
|
|
ON CONFLICT(gitea_login) DO UPDATE SET role = 'owner', active = 1""",
|
|
(login, login),
|
|
)
|
|
app.logger.info("Seeded %r as owner.", login)
|