Decap looks like a different product because it cannot be made to look like this one: its maintainer's answer is override the CSS and accept that class names move between releases, or fork it and carry that forever. Neither is worth building on, so editing moves into the app that already has the site's design and this project's tests. Posts are files in git, so the editor is a form that commits a file through Gitea's contents API. No working copy, no queue, no new state, and no way for the pipeline to tell which editor wrote the file — which is what makes running both at once safe. Decap keeps working; nothing here removes it, and the fallback if something is missing is switching tabs. Filenames and frontmatter are not this module's to invent. They are the contract scripts/translate.py reads: `<basename>.es.md` is what split_lang() parses, the date prefix is what keeps two posts with one title off a single URL, and the absence of `translated_from` is what marks a file as something a person wrote. Several tests import translate.py and run its own parser over what the editor produced, because a file it cannot parse publishes in Spanish and is never translated, with nothing reported anywhere. Commits carry the writer's own Gitea account rather than a bot's, so history says who wrote each post and Gitea's permissions apply unchanged. That needs their access token, which lives in the database and never in a cookie: Flask signs cookies but does not encrypt them, and a token is enough to commit as its owner. Gitea expires tokens after about an hour, so they refresh ahead of expiry and retry once on rejection — without that, saving would start failing partway through an afternoon for no reason the writer could see. Publishing is admin-only. Posting to the internal board and publishing to the public site are different permissions, and the second is the larger grant. Listing caches frontmatter against the git blob sha, because the contents API returns names without bodies: that turns one request per post on every page load into one request in total, and needs no invalidation, since a sha changes only when the file does. Verified: 97 checks. The filename translate.py parses, an authored source that is_generated() rejects, the freeze toggle round-tripping, a stale sha refused with the other edit intact, six filename shapes that must 404 including a generated sibling, plain members refused, an SVG rejected as an image, uploads not colliding, the cache reading each file once and refreshing when it changes, and a preview that renders markdown, escapes script tags and publishes nothing. Smoke-tested live: routes register and gate correctly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NizVpJ2dwzCbjCrTLCjeHn
311 lines
12 KiB
Python
311 lines
12 KiB
Python
"""The editor.
|
|
|
|
Gitea is replaced by a dictionary. What matters here is not that HTTP works —
|
|
`requests` can be trusted for that — but that the files this produces are the
|
|
files `scripts/translate.py` expects, because a post the pipeline cannot parse
|
|
publishes in Spanish and is never translated, silently. Several tests therefore
|
|
import the real translate.py and run its parser over what the editor wrote.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import hashlib
|
|
import importlib.util
|
|
import io
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from apps.board import content, gitea
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[3]
|
|
|
|
|
|
def _load_translate():
|
|
"""Import scripts/translate.py directly — it is a script, not a package."""
|
|
sys.path.insert(0, str(REPO_ROOT / "scripts"))
|
|
spec = importlib.util.spec_from_file_location(
|
|
"vl_translate", REPO_ROOT / "scripts" / "translate.py")
|
|
module = importlib.util.module_from_spec(spec)
|
|
spec.loader.exec_module(module)
|
|
return module
|
|
|
|
|
|
translate = _load_translate()
|
|
|
|
|
|
class FakeRepo:
|
|
"""A repository in a dict, with shas that change when content does."""
|
|
|
|
def __init__(self):
|
|
self.files: dict[str, bytes] = {}
|
|
self.commits: list[str] = []
|
|
self.reads = 0
|
|
|
|
@staticmethod
|
|
def _sha(data: bytes) -> str:
|
|
return hashlib.sha1(data).hexdigest()
|
|
|
|
def list_directory(self, path, token=None):
|
|
out = []
|
|
for name, data in self.files.items():
|
|
if name.startswith(path + "/") and "/" not in name[len(path) + 1:]:
|
|
out.append({"name": name.rsplit("/", 1)[1], "path": name,
|
|
"type": "file", "sha": self._sha(data)})
|
|
return out
|
|
|
|
def read_file(self, path, token=None):
|
|
self.reads += 1
|
|
if path not in self.files:
|
|
raise gitea.GiteaError("Ese archivo ya no existe.")
|
|
return self.files[path].decode("utf-8"), self._sha(self.files[path])
|
|
|
|
def write_file(self, path, data, message, token=None, sha=None):
|
|
if sha and self.files.get(path) is not None and self._sha(self.files[path]) != sha:
|
|
raise gitea.StaleFile("Alguien más guardó este archivo mientras lo editabas.")
|
|
self.files[path] = data
|
|
self.commits.append(message)
|
|
return self._sha(data)
|
|
|
|
def delete_file(self, path, sha, message, token=None):
|
|
self.files.pop(path, None)
|
|
self.commits.append(message)
|
|
|
|
|
|
@pytest.fixture
|
|
def repo(monkeypatch):
|
|
fake = FakeRepo()
|
|
for name in ("list_directory", "read_file", "write_file", "delete_file"):
|
|
monkeypatch.setattr(gitea, name, getattr(fake, name))
|
|
return fake
|
|
|
|
|
|
@pytest.fixture
|
|
def editor(db, make_member, sign_in):
|
|
"""An admin with a stored Gitea token, which every content route needs."""
|
|
member_id = make_member("editora", role="admin")
|
|
db.execute(
|
|
"""INSERT INTO gitea_tokens (member_id, access_token, refresh_token, expires_at)
|
|
VALUES (?, 'tok', 'ref', NULL)""",
|
|
(member_id,),
|
|
)
|
|
sign_in(member_id)
|
|
return member_id
|
|
|
|
|
|
def publish(post, title="Sabores del barrio", body="Texto del artículo.", **extra):
|
|
data = {"title": title, "body": body, "date": "2026-09-25"}
|
|
data.update(extra)
|
|
return post("/comunidad/contenido/post/nuevo", data)
|
|
|
|
|
|
# --- the contract with the pipeline --------------------------------------
|
|
|
|
def test_the_filename_is_one_translate_py_can_parse(repo, editor, post):
|
|
publish(post)
|
|
path, = repo.files
|
|
assert path == "content/post/2026-09-25-sabores-del-barrio.es.md"
|
|
assert translate.split_lang(Path(path)) == ("2026-09-25-sabores-del-barrio", "es")
|
|
|
|
|
|
def test_accents_are_folded_not_dropped():
|
|
assert content.slugify("Gastronomía en Viena") == "gastronomia-en-viena"
|
|
assert content.slugify("¿Qué comer?") == "que-comer"
|
|
assert content.slugify("—") == "sin-titulo"
|
|
|
|
|
|
def test_the_frontmatter_marks_an_authored_source(repo, editor, post):
|
|
publish(post, categories="Gastronomía", description="Un resumen.")
|
|
path, = repo.files
|
|
fm, body = translate.split_frontmatter(repo.files[path].decode())
|
|
assert fm["lang"] == "es"
|
|
assert fm["manual_translation"] is False
|
|
assert fm["categories"] == ["Gastronomía"]
|
|
assert "translated_from" not in fm # what makes it a source, not output
|
|
assert not translate.is_generated(fm)
|
|
assert body.strip() == "Texto del artículo."
|
|
|
|
|
|
def test_two_posts_with_one_title_land_on_different_days(repo, editor, post):
|
|
publish(post, title="Resumen del mes", date="2026-09-25")
|
|
publish(post, title="Resumen del mes", date="2026-10-25")
|
|
assert sorted(repo.files) == [
|
|
"content/post/2026-09-25-resumen-del-mes.es.md",
|
|
"content/post/2026-10-25-resumen-del-mes.es.md",
|
|
]
|
|
|
|
|
|
def test_the_freeze_toggle_round_trips(repo, editor, post, client):
|
|
publish(post, manual_translation="on")
|
|
path, = repo.files
|
|
fm, _ = translate.split_frontmatter(repo.files[path].decode())
|
|
assert translate.is_frozen(fm)
|
|
|
|
name = path.rsplit("/", 1)[1]
|
|
body = client.get(f"/comunidad/contenido/post/editar/{name}").get_data(as_text=True)
|
|
assert 'name="manual_translation" checked' in body.replace(" ", " ")
|
|
|
|
|
|
def test_pages_are_not_dated(repo, editor, post):
|
|
post("/comunidad/contenido/page/nuevo", {"title": "Acerca", "body": "Quiénes somos."})
|
|
assert list(repo.files) == ["content/page/acerca.es.md"]
|
|
|
|
|
|
def test_the_commit_message_does_not_skip_translation(repo, editor, post):
|
|
publish(post)
|
|
assert repo.commits and all("[skip-translate]" not in m for m in repo.commits)
|
|
|
|
|
|
# --- concurrency and safety ----------------------------------------------
|
|
|
|
def test_a_stale_sha_is_refused_with_something_readable(repo, editor, post, client):
|
|
publish(post)
|
|
path, = repo.files
|
|
name = path.rsplit("/", 1)[1]
|
|
repo.files[path] = "---\ntitle: Otra cosa\n---\n\nAlguien llegó antes.\n".encode()
|
|
|
|
response = post(f"/comunidad/contenido/post/editar/{name}",
|
|
{"title": "Mi versión", "body": "Texto", "date": "2026-09-25",
|
|
"sha": "unasha-vieja"})
|
|
assert response.status_code == 400
|
|
assert "Alguien más guardó" in response.get_data(as_text=True)
|
|
assert b"Alguien" in repo.files[path] # the other edit survived
|
|
|
|
|
|
@pytest.mark.parametrize("name", [
|
|
"..%2F..%2Fetc%2Fpasswd", ".woodpecker.yml", "config.yaml",
|
|
"hola.de.md", "hola.es.md.bak", "a/b.es.md",
|
|
])
|
|
def test_only_spanish_source_filenames_are_reachable(repo, editor, client, name):
|
|
assert client.get(f"/comunidad/contenido/post/editar/{name}").status_code == 404
|
|
|
|
|
|
def test_a_generated_sibling_is_hidden_and_refused(repo, editor, client):
|
|
repo.files["content/post/hola.es.md"] = (
|
|
b"---\ntitle: Hola\nlang: es\ntranslated_from: de\n---\n\nGenerado.\n")
|
|
assert "Hola" not in client.get("/comunidad/contenido").get_data(as_text=True)
|
|
|
|
response = client.get("/comunidad/contenido/post/editar/hola.es.md",
|
|
follow_redirects=True)
|
|
assert "traducción automática" in response.get_data(as_text=True)
|
|
|
|
|
|
def test_deleting_leaves_the_siblings_to_the_pipeline(repo, editor, post):
|
|
publish(post)
|
|
path, = repo.files
|
|
repo.files["content/post/2026-09-25-sabores-del-barrio.de.md"] = b"generado"
|
|
|
|
post(f"/comunidad/contenido/post/eliminar/{path.rsplit('/', 1)[1]}")
|
|
assert path not in repo.files
|
|
# Reaping the German file is translate.py's job, on the next run.
|
|
assert "content/post/2026-09-25-sabores-del-barrio.de.md" in repo.files
|
|
|
|
|
|
# --- who may publish -----------------------------------------------------
|
|
|
|
CONTENT_ROUTES = [
|
|
"/comunidad/contenido",
|
|
"/comunidad/contenido/post",
|
|
"/comunidad/contenido/post/nuevo",
|
|
]
|
|
|
|
|
|
@pytest.mark.parametrize("path", CONTENT_ROUTES)
|
|
def test_a_plain_member_cannot_publish(repo, client, make_member, sign_in, path):
|
|
"""Posting to the board is not the same permission as publishing to the
|
|
public site, so the editor is admins and the owner only."""
|
|
sign_in(make_member("vecina"))
|
|
assert client.get(path).status_code == 403
|
|
|
|
|
|
@pytest.mark.parametrize("path", CONTENT_ROUTES)
|
|
def test_anonymous_is_sent_to_login(repo, client, path):
|
|
response = client.get(path)
|
|
assert response.status_code == 302
|
|
assert "/comunidad/login" in response.headers["Location"]
|
|
|
|
|
|
def test_a_member_without_a_token_is_sent_back_through_gitea(
|
|
repo, client, make_member, sign_in):
|
|
sign_in(make_member("sintoken", role="admin"))
|
|
response = client.get("/comunidad/contenido")
|
|
assert response.status_code == 302
|
|
assert "/comunidad/login" in response.headers["Location"]
|
|
|
|
|
|
# --- images --------------------------------------------------------------
|
|
|
|
def _image(name="foto.jpg", size=32):
|
|
return (io.BytesIO(b"x" * size), name)
|
|
|
|
|
|
def test_an_uploaded_image_is_committed_and_referenced(repo, editor, post):
|
|
publish(post, picture=_image())
|
|
uploads = [p for p in repo.files if p.startswith("static/uploads/")]
|
|
assert len(uploads) == 1
|
|
document = repo.files["content/post/2026-09-25-sabores-del-barrio.es.md"].decode()
|
|
fm, _ = translate.split_frontmatter(document)
|
|
assert fm["image"].startswith("/uploads/")
|
|
assert fm["image"].endswith(".jpg")
|
|
|
|
|
|
def test_two_uploads_of_one_filename_do_not_collide(repo, editor, post):
|
|
publish(post, title="Uno", picture=_image())
|
|
publish(post, title="Dos", picture=_image())
|
|
uploads = [p for p in repo.files if p.startswith("static/uploads/")]
|
|
assert len(uploads) == 2
|
|
|
|
|
|
def test_a_script_disguised_as_an_image_is_refused(repo, editor, post):
|
|
response = publish(post, picture=_image("payload.svg"))
|
|
assert response.status_code == 400
|
|
assert "Formato de imagen no admitido" in response.get_data(as_text=True)
|
|
assert not repo.files
|
|
|
|
|
|
def test_an_oversized_image_says_so_instead_of_failing(app, repo, editor, post):
|
|
app.config["UPLOAD_MAX_BYTES"] = 1024
|
|
response = publish(post, picture=_image(size=4096))
|
|
assert response.status_code == 400
|
|
assert "máximo" in response.get_data(as_text=True)
|
|
|
|
|
|
# --- listing, preview, cache ---------------------------------------------
|
|
|
|
def test_the_listing_reads_each_file_once(repo, editor, client):
|
|
publish_paths = {
|
|
"content/post/2026-09-01-uno.es.md": b"---\ntitle: Uno\ndate: 2026-09-01\nlang: es\n---\n\nA\n",
|
|
"content/post/2026-09-02-dos.es.md": b"---\ntitle: Dos\ndate: 2026-09-02\nlang: es\n---\n\nB\n",
|
|
}
|
|
repo.files.update(publish_paths)
|
|
|
|
client.get("/comunidad/contenido")
|
|
after_first = repo.reads
|
|
assert after_first == 2
|
|
|
|
body = client.get("/comunidad/contenido").get_data(as_text=True)
|
|
assert repo.reads == after_first # served from content_cache
|
|
assert "Uno" in body and "Dos" in body
|
|
|
|
|
|
def test_the_listing_refreshes_when_a_file_changes(repo, editor, client):
|
|
repo.files["content/post/2026-09-01-uno.es.md"] = (
|
|
b"---\ntitle: Uno\ndate: 2026-09-01\nlang: es\n---\n\nA\n")
|
|
client.get("/comunidad/contenido")
|
|
repo.files["content/post/2026-09-01-uno.es.md"] = (
|
|
b"---\ntitle: Uno corregido\ndate: 2026-09-01\nlang: es\n---\n\nA\n")
|
|
body = client.get("/comunidad/contenido").get_data(as_text=True)
|
|
assert "Uno corregido" in body
|
|
|
|
|
|
def test_the_preview_renders_markdown_and_escapes_html(repo, editor, post):
|
|
response = post("/comunidad/contenido/post/vista-previa", {
|
|
"title": "Prueba", "date": "2026-09-25",
|
|
"body": "**fuerte** y <script>alert(1)</script>",
|
|
})
|
|
page = response.get_data(as_text=True)
|
|
assert "<strong>fuerte</strong>" in page
|
|
assert "<script>alert(1)</script>" not in page
|
|
assert not repo.files # a preview must not publish anything
|